Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: 2.0.1 -> 2.0.2 #92841

Merged
merged 1 commit into from Jul 10, 2020
Merged

podman: 2.0.1 -> 2.0.2 #92841

merged 1 commit into from Jul 10, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jul 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

saschagrunert
saschagrunert approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adisbladis
Copy link
Member Author

@GrahamcOfBorg test podman

vdemeester
vdemeester approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@adisbladis adisbladis merged commit 7547939 into NixOS:master Jul 10, 2020
@adisbladis
Copy link
Member Author

Merging quickly as podman >2.0 was completely broken on systems without cgroupsv1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@zowoq zowoq Awaiting requested review from zowoq

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @vdemeester @saschagrunert