nfs-ganesha: init at 3.3 #92813
Merged
nfs-ganesha: init at 3.3 #92813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jul 10, 2020
| sha256 = "1w48rqrbqah0hnirvjdz8lyr9ah8b73j3cgsppb04gnrmpssgmb6"; | ||
| }; | ||
|
|
||
| patches = [ ./sysstatedir.patch ]; |
There was a problem hiding this comment.
What is the point of this patch? If this is a support for runstatedir, could this patch be opened upstream?
There was a problem hiding this comment.
Problem is that @SYSSTATEDIR@ contains the prefix, which is used here for the pid file (that should maybe be runstatedir?) as well as for /var/lib. On anything else than nix/NixOS that might actually be OK. However, for us this means that the daemon tries to create files in the nix store.
There was a problem hiding this comment.
@jtojnar For now I do not see a possibility to get rid of the patch. Should we move forward with the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
NFS daemon that runs in user space.
Things done
ntirpcat 3.3, which is a required library.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)