Reland: Abstract portal activation handling to avoid hack of making a fake promise. #24536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 9, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2290231
branch
from
9e4bbf3
to
5bc8b9e
Compare
… fake promise. This is somewhat verbose, but allows us to avoid the unhandled rejection being visible to script without having to make this hack even worse. Instead of actually calling activate(), this mirrors the spec structure by simply calling to underlying logic, passing a resolver where it makes sense and not (in this case, passing a substitute object) where it doesn't. The web test is added to SlowTests because it uses timeouts to check that things don't happen, and the additional test makes the timeouts 6 seconds total -- which is the test runner timeout. Slow tests get 5x longer before they are aborted. The alternative would have been to shorten the timeouts in this test, but that may have made the test more flaky. Bug: 1102081 Change-Id: Ied9d26e32ee426bf0a135279a9063f104d0e6460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290231 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786912}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2290231
branch
from
5bc8b9e
to
25e9d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat verbose, but allows us to avoid the unhandled rejection
being visible to script without having to make this hack even worse.
Instead of actually calling activate(), this mirrors the spec structure
by simply calling to underlying logic, passing a resolver where it makes
sense and not (in this case, passing a substitute object) where it
doesn't.
The web test is added to SlowTests because it uses timeouts to check
that things don't happen, and the additional test makes the timeouts 6
seconds total -- which is the test runner timeout. Slow tests get 5x
longer before they are aborted. The alternative would have been to
shorten the timeouts in this test, but that may have made the test more
flaky.
Bug: 1102081
Change-Id: Ied9d26e32ee426bf0a135279a9063f104d0e6460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290231
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786912}