Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.28.2 -> 2.28.3 #92806

Merged
merged 1 commit into from Jul 9, 2020
Merged

webkitgtk: 2.28.2 -> 2.28.3 #92806

merged 1 commit into from Jul 9, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jul 9, 2020

Motivation for this change

Version bump for webkitgtk. Took 3-4 hours to compile on my system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from worldofpeace, jtojnar and hedning July 9, 2020 19:11
@jtojnar
Copy link
Contributor

jtojnar commented Jul 9, 2020

ANN: https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html

Why is systemd propagated?

@dasj19
Copy link
Contributor Author

dasj19 commented Jul 9, 2020

Why is systemd propagated?

Oh, that is a leftover from my branch when I tried to update it to 2.29.3 (which is unstable)... I'll see if it builds without systemd (which it should). and the update the PR.

@jtojnar jtojnar merged commit 9d6f01a into NixOS:master Jul 9, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 9, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @jtojnar