Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.clikit: make it installable on python3.5 #93669

Merged
merged 2 commits into from Jul 23, 2020
Merged

pythonPackages.clikit: make it installable on python3.5 #93669

merged 2 commits into from Jul 23, 2020

Conversation

ento
Copy link
Contributor

@ento ento commented Jul 22, 2020

Motivation for this change

nix-build ./default.nix -A python35Packages.clikit --no-out-link fails with this error:

ERROR: Package 'crashtest' requires a different Python: 3.5.9 not in '>=3.6,<4.0'

(This was against: 017c7a4, Nix 2.3.1)

Diagnosis: crashtest shouldn't be a dependency when python version is <3.6:
https://github.com/sdispater/clikit/blob/0.6.2/pyproject.toml#L25

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ento added 2 commits July 22, 2020 11:36
@ento
pythonPackages.crashtest: mirror the python version range specified i…
f962fda 
…n pyproject.toml

Trying to build crashtest with python35 fails with:

> ERROR: Package 'crashtest' requires a different Python: 3.5.9 not in
> '>=3.6,<4.0'
@ento
pythonPackages.clikit: fix dependency on crashtest
cfe826a 
From clikit's pyproject.toml:

> Crashtest is only needed for Python ^3.6 to provide
> better error messsages
@ofborg ofborg bot requested a review from jbaum98 July 22, 2020 19:57
@FRidh FRidh merged commit 4e0f911 into NixOS:master Jul 23, 2020
@ento ento deleted the fix-pythonpackages-clikit branch July 23, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ento @FRidh