Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniflux: 2.0.21 -> 2.0.23 #93670

Merged
merged 1 commit into from Sep 19, 2020
Merged

miniflux: 2.0.21 -> 2.0.23 #93670

merged 1 commit into from Sep 19, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 22, 2020 •
edited

Motivation for this change

Changelog: https://github.com/miniflux/miniflux/releases/tag/2.0.22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Jul 22, 2020

cc @rvolosatovs @benpye

@etu
Copy link
Contributor Author

etu commented Jul 22, 2020

@ofborg build miniflux miniflux.tests

rvolosatovs
rvolosatovs approved these changes Jul 22, 2020
View reviewed changes
pkgs/servers/miniflux/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit July 23, 2020 14:52
rvolosatovs
rvolosatovs reviewed Jul 30, 2020
View reviewed changes
pkgs/servers/miniflux/default.nix Outdated Show resolved Hide resolved
pkgs/servers/miniflux/deps.nix Outdated Show resolved Hide resolved
@etu etu force-pushed the miniflux-update branch 2 times, most recently from 136154f to 6b5096e Compare August 3, 2020 10:42
@etu
Copy link
Contributor Author

etu commented Aug 3, 2020

@ofborg build miniflux miniflux.tests

@mweinelt
Copy link
Member

Can you update to 2.0.23?

@etu
Copy link
Contributor Author

etu commented Sep 19, 2020

@ofborg build miniflux miniflux.tests

@etu etu changed the title miniflux: 2.0.21 -> 2.0.22 miniflux: 2.0.21 -> 2.0.23 Sep 19, 2020
@mweinelt mweinelt merged commit a58c4fe into NixOS:master Sep 19, 2020
@mweinelt
Copy link
Member

Thanks!

@etu etu deleted the miniflux-update branch September 19, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@mweinelt mweinelt mweinelt approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @mweinelt @rvolosatovs