Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncplay: use python 3.7 #93677

Merged
merged 1 commit into from Jul 23, 2020
Merged

syncplay: use python 3.7 #93677

merged 1 commit into from Jul 23, 2020

Conversation

ashkitten
Copy link
Contributor

Motivation for this change

Syncplay/syncplay#283
this can be removed when pyside updates to a version that supports python 3.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Tested and LGTM.

Result of nixpkgs-review pr 93677 1

1 package built:
- syncplay

@ashkitten
syncplay: use python 3.7
9d828db 
Syncplay/syncplay#283
this can be removed when pyside updates to a version that supports
python 3.8
@mweinelt mweinelt merged commit c61b6b1 into NixOS:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashkitten @mweinelt