Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube3d 1.7.0 -> 3.0.0 #93680

Merged
merged 3 commits into from Jul 28, 2020
Merged

kube3d 1.7.0 -> 3.0.0 #93680

merged 3 commits into from Jul 28, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Jul 22, 2020

As small-big step.

@blaggacao blaggacao changed the title Da kube3d update kube3d 1.7.0 -> 3.0.0 Jul 22, 2020
@blaggacao
Copy link
Contributor Author

/marvin opt-in

@blaggacao
Copy link
Contributor Author

Result of nixpkgs-review pr 93680 1

1 package built:
- kube3d

@blaggacao
Copy link
Contributor Author

[nix-shell:~/.cache/nixpkgs-review/pr-93680-1]$ ./results/kube3d/bin/k3d --helphttps://k3d.io/
k3d is a wrapper CLI that helps you to easily create k3s clusters inside docker.
Nodes of a k3d cluster are docker containers running a k3s image.
All Nodes of a k3d cluster are part of the same docker network.

Usage:
  k3d [flags]
  k3d [command]

Available Commands:
  cluster     Manage cluster(s)
  completion  Generate completion scripts for [bash, zsh, powershell | psh]
  help        Help about any command
  image       Handle container images.
  kubeconfig  Manage kubeconfig(s)
  node        Manage node(s)
  version     Show k3d and default k3s version

Flags:
  -h, --help      help for k3d
      --verbose   Enable verbose output (debug logging)
      --version   Show k3d and default k3s version

Use "k3d [command] --help" for more information about a command.

@blaggacao
Copy link
Contributor Author

blaggacao commented Jul 23, 2020

Validated k3d --version is set (introduced v3 suffix to the module path)

$ k3d --version
k3d version 3.0.0
k3s version v1.18.6-k3s1 (default)

@blaggacao blaggacao force-pushed the da-kube3d-update branch 2 times, most recently from fd66d6a to 81c5ab3 Compare July 23, 2020 01:05
docker pull rancher/k3d-proxy:3.0.0
Error response from daemon: manifest for rancher/k3d-proxy:3.0.0 not found: manifest unknown: manifest unknown

vs

docker pull rancher/k3d-proxy:v3.0.0
v3.0.0: Pulling from rancher/k3d-proxy

The version tag selects the image tag.
@blaggacao
Copy link
Contributor Author

  • k3d cluster create successfully creates a cluster

Copy link
Member

@kuznero kuznero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blaggacao
Copy link
Contributor Author

Skaffold has an optional dependency on k3d. Yesterday compatibility with k3d v3 was merged and will be the only supported version going forward, so ahortly after skaffold cuts a releas I'll update skaffold as well.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/231

@blaggacao
Copy link
Contributor Author

Could we merge this?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/191

@jlesquembre
Copy link
Member

LGTM!

@jlesquembre
Copy link
Member

/status needs_merger

@timokau
Copy link
Member

timokau commented Jul 28, 2020

You probably want to set your PR to needs_reviewer after opting-in @blaggacao :) That way you could theoretically get an assigned reviewer (though there currently aren't enough of those).

@timokau
Copy link
Member

timokau commented Jul 28, 2020

Thanks @blaggacao @jlesquembre!

@timokau timokau merged commit 09e7fb1 into NixOS:master Jul 28, 2020
@blaggacao blaggacao deleted the da-kube3d-update branch August 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants