Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlx: cleanup #93655

Merged
merged 1 commit into from Apr 5, 2021
Merged

dlx: cleanup #93655

merged 1 commit into from Apr 5, 2021

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Noticed this derivation looked a bit old. What I've done is a bit cleaner IMO.

homepage url also seemed to have gotten moved, the old one redirects to an generic page on the authors website.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

9999years
9999years approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@9999years 9999years left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IvarWithoutBones
Copy link
Member Author

Resolved conflicts, and adressed review commits.

Should be ready to merge @SuperSandro2000 :)

@SuperSandro2000 SuperSandro2000 changed the title dlx: fixup dlx: cleanup Apr 5, 2021
@SuperSandro2000 SuperSandro2000 merged commit 2870b31 into NixOS:master Apr 5, 2021
@IvarWithoutBones IvarWithoutBones deleted the dlx-fixup branch April 5, 2021 07:42
cideM pushed a commit to cideM/nixpkgs that referenced this pull request Apr 9, 2021
@IvarWithoutBones @cideM
dlx: cleanup (NixOS#93655)
ca428d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@9999years 9999years 9999years approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @SuperSandro2000 @9999years