lxsession: init at 0.5.5 #93645
Merged
lxsession: init at 0.5.5 #93645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
suggested changes
Jul 22, 2020
There was a problem hiding this comment.
Few comments (see below)
- Diff has a few issues.
- Builds cleanly via
nix-review - Commits LGTM
@GrahamcOfBorg build lxsession
$ nix-review pr 93645
https://github.com/NixOS/nixpkgs/pull/93645
1 package built:
lxsession
SCOTT-HAMILTON
force-pushed
the
lxsession
branch
from
7bce80f
to
1d5346c
Compare
drewrisinger
approved these changes
Jul 22, 2020
sikmir
reviewed
Jul 25, 2020
SCOTT-HAMILTON
force-pushed
the
lxsession
branch
from
1d5346c
to
885793f
Compare
SCOTT-HAMILTON
force-pushed
the
lxsession
branch
2 times, most recently
from
9f9ab14
to
6abaaf4
Compare
|
Nix-review: |
doronbehar
requested changes
Dec 18, 2020
|
@SCOTT-HAMILTON ping |
SCOTT-HAMILTON
force-pushed
the
lxsession
branch
from
6abaaf4
to
eb040e5
Compare
SCOTT-HAMILTON
force-pushed
the
lxsession
branch
from
eb040e5
to
5f51653
Compare
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed lxpolkit
Things done
Packaged lxsession with documentation, without buitin clipboard and without builtin polkit (same as arch package).
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)