Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: use LLVM 10 #93656

Merged
merged 1 commit into from Jul 31, 2020
Merged

rustc: use LLVM 10 #93656

merged 1 commit into from Jul 31, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Jul 22, 2020 •
edited

Fixes rust-lang/rust#74585

Motivation for this change

This version is used by rustup build of Rust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: rust label Jul 22, 2020
@ofborg ofborg bot requested review from globin, cstrahan and madjar July 22, 2020 16:15
@doronbehar
Copy link
Contributor

Interesting.. Related: #87847

@ggreif
Copy link
Contributor

ggreif commented Jul 22, 2020

Heads up: LLVM 10.0.1 is out, and #88248 will probably land soon.

@FRidh FRidh merged commit 41d681c into NixOS:staging Jul 31, 2020
@aaronjanse
Copy link
Member

For future travelers: using LLVM 10 fixes "LLVM ERROR: Bad $ operand number" when using Rust's new asm! syntax. That took me a while to figure out.

Thank you @FRidh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@globin globin Awaiting requested review from globin

@cstrahan cstrahan Awaiting requested review from cstrahan

@madjar madjar Awaiting requested review from madjar

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KamilaBorowska @doronbehar @ggreif @aaronjanse @FRidh