Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneDNN: use SSE 4.1 when running tests #93692

Merged
merged 1 commit into from Jul 23, 2020
Merged

oneDNN: use SSE 4.1 when running tests #93692

merged 1 commit into from Jul 23, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Build of oneDNN failed in Hydra, with illegal instructions while running tests:

https://hydra.nixos.org/build/124285930/nixlog/1

Since tests do pass on my machine, ofborg, and I think @marsam 's machine (update to 1.5.1), I think feature detection fails on the Hydra builder? (Most likely depending on the builder?)

This change caps tests at SSE 4.1, which is supported on many Intel/AMD CPUs since 2006/2007. If tests pass with SSE 4.1, oneDNN is most likely correctly built and this makes the build more resistant against feature detection problems on builders.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
oneDNN: use SSE 4.1 when running tests
24737e5 
Feature detection may fail, leading to illegal instructions when
running tests. Cap tests at SSE 4.1, which is supported on many
Intel/AMD CPUs since 2006/2007.
@danieldk danieldk requested a review from marsam July 23, 2020 07:11
@ofborg ofborg bot requested review from bhipple and alexarice July 23, 2020 07:19
@danieldk danieldk merged commit bb259af into NixOS:master Jul 23, 2020
@danieldk danieldk deleted the onednn-test-baseline-simd branch July 23, 2020 18:28
@danieldk
Copy link
Contributor Author

Still fails :( :

https://hydra.nixos.org/build/124332944/nixlog/1

@danieldk danieldk mentioned this pull request Jul 24, 2020
Merged
10 tasks
danieldk added a commit to danieldk/nixpkgs that referenced this pull request Jul 30, 2020
@danieldk
oneDNN: disable tests to avoid illegal instructions
2598f0e 
oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues NixOS#93692 and NixOS#93747.
@danieldk danieldk mentioned this pull request Jul 30, 2020
Merged
10 tasks
braack pushed a commit to braack/nixpkgs that referenced this pull request Oct 29, 2020
@danieldk
oneDNN: disable tests to avoid illegal instructions
3772404 
oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues NixOS#93692 and NixOS#93747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@bhipple bhipple Awaiting requested review from bhipple

@alexarice alexarice Awaiting requested review from alexarice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @marsam