Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipewire: 0.3.6 -> 0.3.7 #93672

Merged
merged 1 commit into from Jul 23, 2020
Merged

pipewire: 0.3.6 -> 0.3.7 #93672

merged 1 commit into from Jul 23, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jul 22, 2020 •
edited

Motivation for this change

changelog: PipeWire/pipewire@0.3.6...0.3.7

including a patch from our very own @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm changed the title pipewire: 0.3.5 -> 0.3.7 pipewire: 0.3.6 -> 0.3.7 Jul 22, 2020
@zimbatm zimbatm requested a review from jtojnar July 22, 2020 21:13
@worldofpeace
Copy link
Contributor

@ofborg test gnome3

worldofpeace
worldofpeace suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the old patch that is included in the archive

@zimbatm
Copy link
Member Author

zimbatm commented Jul 22, 2020

@ofborg test gnome3

@worldofpeace worldofpeace merged commit e66b7f6 into NixOS:master Jul 23, 2020
@worldofpeace
Copy link
Contributor

Thanks @zimbatm ✨

@zimbatm zimbatm deleted the pipewire-0.3.7 branch July 23, 2020 11:03
@nglen nglen mentioned this pull request Aug 5, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @worldofpeace