python3Packages.etelemetry: unbreak #93685
Merged
+59
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2020
| sha256 = "12ax07n81vxbyayhwzi1q6x7gfmwmvrvwm1n4ii6qa6fqlp9pzj7"; | ||
| }; | ||
|
|
||
| checkInputs = [ pytest pytestrunner pytestCheckHook ]; |
There was a problem hiding this comment.
pytestrunner needs to be a nativeBuildInputs because it is a setup requires https://github.com/grantmcconnaughey/ci.py/blob/master/setup.py#L10. Very annoying that this has proliferated throughout the python ecosystem
There was a problem hiding this comment.
I should elaborate why. If you were to disable checks it would fail at setup always
There was a problem hiding this comment.
Thanks, I didn't realize that. Fixed.
|
@ofborg build python36Packages.etelemetry python37Packages.eteletmetry python38Packages.etelemetry |
ofborg
bot
added
8.has: package (new)
bcdarwin
force-pushed
the
unbreak-etelemetry
branch
from
75ebf22 to
323ba8a
Compare
|
@ofborg build python36Packages.etelemetry python37Packages.eteletmetry python38Packages.etelemetry |
|
Thanks for the fixes @bcdarwin ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by adding dependencies missed in the last Python mass update
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)