Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.etelemetry: unbreak #93685

Merged
merged 3 commits into from Jul 23, 2020
Merged

python3Packages.etelemetry: unbreak #93685

merged 3 commits into from Jul 23, 2020

Conversation

bcdarwin
Copy link
Member

by adding dependencies missed in the last Python mass update

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Jul 23, 2020
Closed
Merged
worldofpeace
worldofpeace reviewed Jul 23, 2020
View reviewed changes
pkgs/development/python-modules/ci-py/default.nix Outdated
sha256 = "12ax07n81vxbyayhwzi1q6x7gfmwmvrvwm1n4ii6qa6fqlp9pzj7";
};

checkInputs = [ pytest pytestrunner pytestCheckHook ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytestrunner needs to be a nativeBuildInputs because it is a setup requires https://github.com/grantmcconnaughey/ci.py/blob/master/setup.py#L10. Very annoying that this has proliferated throughout the python ecosystem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should elaborate why. If you were to disable checks it would fail at setup always

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't realize that. Fixed.

@worldofpeace
Copy link
Contributor

@ofborg build python36Packages.etelemetry python37Packages.eteletmetry python38Packages.etelemetry

@worldofpeace
Copy link
Contributor

@ofborg build python36Packages.etelemetry python37Packages.eteletmetry python38Packages.etelemetry

@worldofpeace worldofpeace merged commit 7d557a5 into NixOS:master Jul 23, 2020
@worldofpeace
Copy link
Contributor

Thanks for the fixes @bcdarwin ✨

@bcdarwin bcdarwin deleted the unbreak-etelemetry branch July 23, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @worldofpeace