Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reicast: init at 20.04 #93660

Merged
merged 1 commit into from Dec 17, 2020
Merged

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jul 22, 2020

Motivation for this change

App seems to have quite a few licenses, so i thought I'd just include them all. Not sure what the correct approach here is.

When opening the app up it gives you a warning about not being able to find git, however we can just ignore this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IvarWithoutBones
Copy link
Member Author

Anything blocking this from getting merged?

@doronbehar doronbehar merged commit f42d6f8 into NixOS:master Dec 17, 2020
@IvarWithoutBones IvarWithoutBones deleted the reicast-20.04 branch December 17, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants