Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nibabel: unbreak reverse deps #93684

Merged
merged 1 commit into from Jul 23, 2020
Merged

python3Packages.nibabel: unbreak reverse deps #93684

merged 1 commit into from Jul 23, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jul 23, 2020 •
edited

(nipy, dicom2nifti) by adding missing packaging dependency

(presumably missed after nibabel was recently updated as part of a mass Python update on some non-trunk branch)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    (won't build cleanly due to python3Packages.etelemetry: unbreak #93685, and conversely)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin mentioned this pull request Jul 23, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from ashgillman July 23, 2020 00:18
@worldofpeace worldofpeace merged commit 6ca121a into NixOS:master Jul 23, 2020
@bcdarwin bcdarwin deleted the unbreak-nibabel-reverse-deps branch July 23, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ashgillman ashgillman Awaiting requested review from ashgillman

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @worldofpeace