[20.03] ghc: do not use ld.gold with musl libc #93687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld.gold doesn't play well with musl as is documented in NixOS#49071 and https://sourceware.org/bugzilla/show_bug.cgi?id=23856 (cherry picked from commit 4675649)
(cherry picked from commit 08a9d51)
10 tasks
|
@nh2 Is building something like this sufficient to test that this is working (well, at least for ghc865)? Although I imagine this might timeout on ofborg: @GrahamcOfBorg build pkgsStatic.haskellPackages.lens |
nomeata
added a commit
to nomeata/kaleidogen
that referenced
this pull request
Aug 30, 2020
as described in NixOS/nixpkgs#43795 (comment) thanks to NixOS/nixpkgs#93687 the relevant commits should be in 20.03
nomeata
added a commit
to nomeata/kaleidogen
that referenced
this pull request
Aug 30, 2020
as described in NixOS/nixpkgs#43795 (comment) thanks to NixOS/nixpkgs#93687 the relevant commits should be in 20.03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #84741 and #84809 to fix
pkgsStaticHaskell builds on 20.03.CC @utdemir @adamse @domenkozar
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I did not test, hope the bots do it for me.