-
Notifications
You must be signed in to change notification settings - Fork 157
Zybo and basys harnesses do not contain explicit type #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
https://github.com/mithro/prjxray-db/blob/002032fa463ab11026afde28c7a91e8a2156bb10/artix7/harness/basys3/swbut/design.json#L13 looks good? The basys3 50 MHz is old and can be deleted. Let me check if it is used anywhere. I believe the story is the same for the zybo harness?
|
@mithro Can you delete https://github.com/SymbiFlow/prjxray-db/tree/master/zynq7/harness/zybo/swbut and https://github.com/SymbiFlow/prjxray-db/tree/master/artix7/harness/basys3/swbut_50 If you believe they should still exist, we need to update prjxray to regenerate those harness, as they are currently very old.
|
Shouldn't these be built by https://github.com/SymbiFlow/prjxray/blob/master/Makefile#L197-L231 ? I think we might want to keep the zybo one, but the |
Yes that basys3 harness looks good.
|
The zybo and swbut_50 harnesses are not specified there
Pretty much. The zybo harness never got incorporated into arch-defs, right now we only have the full graph supported.
|
This is no longer required for f4pga/f4pga-arch-defs#1565, but is probably still a good change to make. |
Fixed in f4pga/prjxray-db#13 |
https://github.com/SymbiFlow/prjxray-db/blob/master/zynq7/harness/zybo/swbut/design.json#L13
Code was added in #1383 to add an explicit type to the harness. Not sure why this only adds the type for arty harnesses and not basys3 or zybo.
Needs to be fixed for f4pga/f4pga-arch-defs#1565 now that pin map csv generation has been merged.
The text was updated successfully, but these errors were encountered: