Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zybo and basys harnesses do not contain explicit type #1402

Closed
andrewb1999 opened this issue Jul 23, 2020 · 7 comments
Closed

Zybo and basys harnesses do not contain explicit type #1402

andrewb1999 opened this issue Jul 23, 2020 · 7 comments
Assignees

Comments

@andrewb1999
Copy link
Contributor

https://github.com/SymbiFlow/prjxray-db/blob/master/zynq7/harness/zybo/swbut/design.json#L13

Code was added in #1383 to add an explicit type to the harness. Not sure why this only adds the type for arty harnesses and not basys3 or zybo.

Needs to be fixed for f4pga/f4pga-arch-defs#1565 now that pin map csv generation has been merged.

@litghost
Copy link
Contributor

litghost commented Jul 23, 2020

https://github.com/mithro/prjxray-db/blob/002032fa463ab11026afde28c7a91e8a2156bb10/artix7/harness/basys3/swbut/design.json#L13 looks good? The basys3 50 MHz is old and can be deleted. Let me check if it is used anywhere.

I believe the story is the same for the zybo harness?

GitHub
Project X-Ray Database: XC7 Series. Contribute to mithro/prjxray-db development by creating an account on GitHub.

@litghost
Copy link
Contributor

litghost commented Jul 23, 2020

@mithro Can you delete https://github.com/SymbiFlow/prjxray-db/tree/master/zynq7/harness/zybo/swbut and https://github.com/SymbiFlow/prjxray-db/tree/master/artix7/harness/basys3/swbut_50

If you believe they should still exist, we need to update prjxray to regenerate those harness, as they are currently very old.

GitHub
Project X-Ray Database: XC7 Series. Contribute to SymbiFlow/prjxray-db development by creating an account on GitHub.
GitHub
Project X-Ray Database: XC7 Series. Contribute to SymbiFlow/prjxray-db development by creating an account on GitHub.

@mithro
Copy link
Contributor

mithro commented Jul 23, 2020

Shouldn't these be built by https://github.com/SymbiFlow/prjxray/blob/master/Makefile#L197-L231 ?

I think we might want to keep the zybo one, but the swbut_50 should be deleted as there is a normal swbut right?

@andrewb1999
Copy link
Contributor Author

andrewb1999 commented Jul 23, 2020

https://github.com/mithro/prjxray-db/blob/002032fa463ab11026afde28c7a91e8a2156bb10/artix7/harness/basys3/swbut/design.json#L13 looks good? The basys3 50 MHz is old and can be deleted. Let me check if it is used anywhere.

I believe the story is the same for the zybo harness?

Yes that basys3 harness looks good.

GitHub
Project X-Ray Database: XC7 Series. Contribute to mithro/prjxray-db development by creating an account on GitHub.

@litghost
Copy link
Contributor

litghost commented Jul 23, 2020

Shouldn't these be built by https://github.com/SymbiFlow/prjxray/blob/master/Makefile#L197-L231 ?

The zybo and swbut_50 harnesses are not specified there

I think we might want to keep the zybo one, but the swbut_50 should be deleted as there is a normal swbut right?

Pretty much. The zybo harness never got incorporated into arch-defs, right now we only have the full graph supported.

GitHub
Documenting the Xilinx 7-series bit-stream format. - SymbiFlow/prjxray

@andrewb1999
Copy link
Contributor Author

This is no longer required for f4pga/f4pga-arch-defs#1565, but is probably still a good change to make.

@litghost
Copy link
Contributor

Fixed in f4pga/prjxray-db#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants