Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlangR23: 23.0.2 -> 23.0.3 #93646

Merged
merged 1 commit into from Jul 23, 2020
Merged

erlangR23: 23.0.2 -> 23.0.3 #93646

merged 1 commit into from Jul 23, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Jul 22, 2020

Motivation for this change

https://github.com/erlang/otp/releases/tag/OTP-23.0.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789
Copy link
Contributor Author

cw789 commented Jul 22, 2020

  • Tested using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93646"

danieldk
danieldk approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93646 1

1 package built:
- erlangR23

Binaries work as expected.

@danieldk danieldk merged commit a8a0dfa into NixOS:master Jul 23, 2020
@cw789 cw789 deleted the erlang_update branch July 24, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cw789 @danieldk