Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hunspell-dicts: add support for Danish dictionary #93651

Closed
wants to merge 1 commit into from
Closed

hunspell-dicts: add support for Danish dictionary #93651

wants to merge 1 commit into from

Conversation

LouisDK1
Copy link
Contributor

Motivation for this change

Danish dictionary for hunspell is missing in nixpkga

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LouisDK1
Copy link
Contributor Author

Changed "name" to "pname" for the Danish language in "dictionaries.nix" hence the force-push.

@Ma27
Copy link
Member

Ma27 commented Jul 22, 2020

@LouisDK1 eval is failing because of your pname change since mkDict is still expecting a name argument.

@LouisDK1
Copy link
Contributor Author

@Ma27 Should be fixed now

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Jul 24, 2020 •
edited

I ran nix-shell -p nixpkgs-review --run "nixpkgs-review wip" locally and installed it locally too without any issue.

Is it failing because of the line: maintainers = with maintainers; [ louisdk1 ]; ?

If so I'll just remove it.

@Ma27
Copy link
Member

Ma27 commented Jul 24, 2020

Are you listed in maintainers/maintainer-list.nix?

@LouisDK1
Copy link
Contributor Author

Are you listed in maintainers/maintainer-list.nix?

No. Removed and new push made.

@Ma27
Copy link
Member

Ma27 commented Jul 24, 2020

Any reason you're not adding yourself there?

@LouisDK1
Copy link
Contributor Author

@Ma27 Not fan of filling out my email address without replacing some signs which does not seem to be allowed.
Maybe I should create a special email address just for this which forwards to my main mail address.

@Ma27
Copy link
Member

Ma27 commented Jul 24, 2020

@LouisDK1 as you can see in the file, it's fine to use the yournick@users.noreply.github.com address there.

@LouisDK1
Copy link
Contributor Author

@Ma27 Done

@LouisDK1 LouisDK1 force-pushed the hunspell-da_DK branch 4 times, most recently from 3b00584 to caa9ca4 Compare July 26, 2020 20:33
@LouisDK1
Copy link
Contributor Author

@rycee Will you help committing this pull req?

rycee pushed a commit that referenced this pull request Jul 29, 2020
@LouisDK1 @rycee
hunspell-dicts: add support for Danish dictionary
f609fa6 
PR #93651
@rycee
Copy link
Member

rycee commented Jul 29, 2020

Sure, looks and builds OK for me. Rebased to master in f609fa6.

@rycee rycee closed this Jul 29, 2020
@LouisDK1 LouisDK1 deleted the hunspell-da_DK branch July 30, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LouisDK1 @Ma27 @rycee @jtojnar