Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ungoogled-chromium: 81.0.4044.138-1 -> 84.0.4147.89-1 #93666

Merged
merged 1 commit into from Jul 23, 2020
Merged

ungoogled-chromium: 81.0.4044.138-1 -> 84.0.4147.89-1 #93666

merged 1 commit into from Jul 23, 2020

Conversation

squalus
Copy link
Member

@squalus squalus commented Jul 22, 2020

Motivation for this change

This updates ungoogled-chromium. This change was created by manually copying the regular chromium expressions and applying a small diff to support the ungoogled patchset.

Performed a cursory test and everything looks good, except for a slight icon/font rendering issue that also appears in the upstream chromium package.

Includes a possible fix for ungoogled-software/ungoogled-chromium#1050 - renames the nix store path with a suffix of ungoogled-chromium instead of chromium, to hopefully allow the nix-env updater to work properly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

ungoogled-chromium: 81.0.4044.138-1 -> 84.0.4147.89-1
ad5c5a6 
based on chromium master@cd03bf0c
@squalus squalus mentioned this pull request Jul 22, 2020
Closed
10 tasks
@danielfullmer
Copy link
Contributor

Built and briefly tested youtube/twitch and webgl.

@primeos
Copy link
Member

primeos commented Jul 23, 2020

@squalus I just noticed that #91430 was ready but sadly never got merged. Feel free to ping/mention me on your ungoogled-chromium PRs then I can merge them after @danielfullmer tested them (thanks for that) ;)

@primeos primeos merged commit 2d6ab6e into NixOS:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squalus @danielfullmer @primeos