ResourceState.definition_type: introduce for run-time accessible definition type validation #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
commented
Jul 22, 2020
| ResourceDefinitionType = TypeVar( | ||
| "ResourceDefinitionType", bound="ResourceDefinition", contravariant=True | ||
| ) | ||
| ResourceDefinitionType = TypeVar("ResourceDefinitionType", bound="ResourceDefinition") |
There was a problem hiding this comment.
I think this is nice, actually, since we really did want it to be invariant I think.
grahamc
force-pushed
the
defntype
branch
6 times, most recently
from
13d36f4
to
93339bf
Compare
|
Ratchet going down was just about unavoidable in this case, so I think it is good to go! |
…use it for the DiffState to get a definition
gilligan
force-pushed
the
defntype
branch
2 times, most recently
from
53fe628
to
1e27841
Compare
|
I think this is in a good enough state to merge it. I've been able to deploy to AWS (with fixes in the AWS plugin) and to libvirt (without any modifications on the code) with this nixops branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is paired with NixOS/nixops-aws#108. Adding these types here showed zillions of type errors in the nixops-aws plugin. #108 fixes a zillion issues in the types, which makes it actually work. :)