New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libhdhomerun: git -> 20200521 #93671
Conversation
I'm a bit unsure why this fails. When I run
Commenting the patchPhase and 3 preceding lines does not help. |
b8fe606
to
d9f1b9f
Compare
Running "nix-shell -p nixpkgs-review --show-trace --run "nixpkgs-review pr 93671" works. Installing package locally on my NixOS works. @titanous Can you check if this package will build on Darwin? It seems like it wants to build with i386 flags which shouldn't be supported on 10.15+. |
5d766b9
to
4736389
Compare
4736389
to
5a967b8
Compare
I don't have a Darwin machine easily available at the moment, someone else will have to test. |
@rycee This package build for me on NixOS but I'm unsure about Darwin (macOS). Should I make it a Linux-only package or what would you suggest? |
I'd suggest asking in #nixos @ freenode if there is any Darwin user that could help out by building the package. Basically it should be sufficient to run $ nix run nixpkgs.nix-review --command nix-review pr 93671 in a Nixpkgs checkout |
Darwin user is here. 1 package marked as broken and skipped:- kodiPlugins.pvr-hdhomerun 1 package built:- libhdhomerun |
Thanks. Does kodiPlugins.pvr-hdhomerun have to be fixed for this package to get merged? |
Since Kodi seems to be limited to Linux I can't imagine it being critical that its plugins build on Darwin. Squashed and rebased to master in 526c859. |
Motivation for this change
New release 20200521 which is not available on Github: https://github.com/Silicondust/libhdhomerun
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)