Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhdhomerun: git -> 20200521 #93671

Closed
wants to merge 2 commits into from

Conversation

LouisDK1
Copy link
Contributor

@LouisDK1 LouisDK1 commented Jul 22, 2020

Motivation for this change

New release 20200521 which is not available on Github: https://github.com/Silicondust/libhdhomerun

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LouisDK1
Copy link
Contributor Author

I'm a bit unsure why this fails.

When I run nix-shell -p nixpkgs-review --run "nixpkgs-review wip I get this error:

error: patch failed: pkgs/development/libraries/libhdhomerun/default.nix:1 error: pkgs/development/libraries/libhdhomerun/default.nix: patch does not apply Failed to apply diff in /home/louis/.cache/nixpkgs-review/rev-c2e6ac97a41835d77084b7623b49ec181884c26b-dirty-10/nixpkgs

Commenting the patchPhase and 3 preceding lines does not help.

@LouisDK1
Copy link
Contributor Author

Running "nix-shell -p nixpkgs-review --show-trace --run "nixpkgs-review pr 93671" works. Installing package locally on my NixOS works.

@titanous Can you check if this package will build on Darwin? It seems like it wants to build with i386 flags which shouldn't be supported on 10.15+.

@LouisDK1 LouisDK1 force-pushed the libhdhomerun20200521 branch 2 times, most recently from 5d766b9 to 4736389 Compare July 26, 2020 13:09
@titanous
Copy link
Contributor

I don't have a Darwin machine easily available at the moment, someone else will have to test.

@LouisDK1
Copy link
Contributor Author

@rycee This package build for me on NixOS but I'm unsure about Darwin (macOS). Should I make it a Linux-only package or what would you suggest?

@rycee
Copy link
Member

rycee commented Jul 30, 2020

I'd suggest asking in #nixos @ freenode if there is any Darwin user that could help out by building the package. Basically it should be sufficient to run

$ nix run nixpkgs.nix-review --command nix-review pr 93671

in a Nixpkgs checkout

@sikmir
Copy link
Member

sikmir commented Jul 30, 2020

Darwin user is here.
Result of nixpkgs-review pr 93671 1

1 package marked as broken and skipped:
- kodiPlugins.pvr-hdhomerun
1 package built:
- libhdhomerun

@LouisDK1
Copy link
Contributor Author

Darwin user is here.
Result of nixpkgs-review pr 93671 1
1 package marked as broken and skipped:

  • kodiPlugins.pvr-hdhomerun
    1 package built:
  • libhdhomerun

Thanks. Does kodiPlugins.pvr-hdhomerun have to be fixed for this package to get merged?

@rycee
Copy link
Member

rycee commented Jul 30, 2020

Since Kodi seems to be limited to Linux I can't imagine it being critical that its plugins build on Darwin. Squashed and rebased to master in 526c859.

@rycee rycee closed this Jul 30, 2020
@LouisDK1 LouisDK1 deleted the libhdhomerun20200521 branch July 30, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants