Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup config / creation issues to work a bit more reliably #108

Merged
merged 16 commits into from Sep 9, 2020
Merged

Fixup config / creation issues to work a bit more reliably #108

merged 16 commits into from Sep 9, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jul 23, 2020

A very sed-driven implementation of the changes at NixOS/nixops#1388. Note the changes in 1388 are because this PR required them.

@grahamc grahamc mentioned this pull request Sep 4, 2020
Merged
@andir andir force-pushed the defntype branch 3 times, most recently from fc7c9f5 to 28f624a Compare September 8, 2020 15:45
@andir andir mentioned this pull request Sep 8, 2020
Merged
@andir andir force-pushed the defntype branch 2 times, most recently from d0faf90 to 99f9ef5 Compare September 8, 2020 16:01
grahamc and others added 16 commits September 9, 2020 15:05
@grahamc @andir
ElasticIp: fixup references to defn.config as an attrset
83f03f3
@grahamc @andir
EC2RDSDbInstance: Return an RDSConnection from _connect
ae0cc3f
@grahamc @andir
AWSVPNConnectionState: give a defined defn type
ebe9d50
@grahamc @andir
AWSVPNConnectionRouteState: Give a defined defn type
7b58751
@grahamc @andir
resources,backends: Specify definition_type
710d19e
@grahamc @andir
VPC: Fixup reference and setting of tags.
5c6c5ba
@grahamc @andir
ec2_common: access the accessKeyId via config
e801d48
@grahamc @andir
Fix an astonishing number of subscript issues
bee2696
@andir
vpc_route: ignore attributes that are None
4f563ec
@andir
vpc_route: use get_generic_resource instead of get_typed_resource
c2d43af
@andir
ebs_volume: use attributes instead of dictionary indexing
35c6f17
@andir
elastic_file_system: use attributes instead of dictionaries
d7939d9
@andir
ebs_volume: fix updating resources (i.e. tags) after creation
c606aac
@andir
efs mount targets: use attribute accessors instead of dict
2591215
@andir
sns: use attributes instead of dictionary access
a23860c
@andir
s3_bucket: add defn type annotation
898714c
@grahamc grahamc merged commit 76f65a2 into NixOS:master Sep 9, 2020
@grahamc grahamc deleted the defntype branch September 9, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @andir