checkbashisms: Remove. Available in debian-devscripts #93665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version was out of date & confusingly emitted perl warnings about itself along with warnings about the shell scripts it checked. The version in debian-devscripts is more recent & doesn't have this problem.
|
I wonder if adding a alias to |
|
I don't think this package is widely used, or there would be more complaints or PRs about it emitting 31 lines of warnings about its own perl syntax before doing its real job and emitting similar-looking warnings about shell syntax in the shell scripts it is invoked on. |
wamserma
reviewed
Oct 26, 2020
| @@ -69,7 +69,6 @@ mapAliases ({ | |||
| casperjs = throw "casperjs has been removed, it was abandoned by upstream and broken."; | |||
| catfish = xfce.catfish; # added 2019-12-22 | |||
| cgmanager = throw "cgmanager was deprecated by lxc and therefore removed from nixpkgs."; # added 2020-06-05 | |||
| checkbashism = checkbashisms; # added 2016-08-16 | |||
There was a problem hiding this comment.
Maybe put a note here that the standalone package has been removed.
SuperSandro2000
requested changes
Nov 26, 2020
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version was out of date & confusingly emitted perl warnings about
itself along with warnings about the shell scripts it checked. The
version in debian-devscripts is more recent & doesn't have this problem.
Motivation for this change
Make it easier to find the real
checkbashisms(it's included indebian-devscripts) by removing this old, broken copy.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"