Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sponsorblock-mpv-script: init at 2020-06-21 #92266

Closed
wants to merge 2 commits into from
Closed

sponsorblock-mpv-script: init at 2020-06-21 #92266

wants to merge 2 commits into from

Conversation

samuelgrf
Copy link
Member

Motivation for this change

mpv_sponsorblock is an (or a?) mpv script that automatically skips sponsors on YouTube videos.

Things done

Successfully tested that mpv skips sponsors with the script installed.
Rewrote the NixOS wiki entry to use overlays, since packageOverrides are deprecated.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samuelgrf samuelgrf force-pushed the initpkg/sponsorblock-mpv-script branch from c744537 to a391550 Compare July 4, 2020 15:48
@samuelgrf samuelgrf changed the title init: sponsorblock-mpv-script at 2020-06-21 sponsorblock-mpv-script: init at 2020-06-21 Jul 4, 2020
@samuelgrf
Copy link
Member Author

Converting this to a draft until a license is added to the project, see po5/mpv_sponsorblock#15

@samuelgrf samuelgrf marked this pull request as draft July 5, 2020 10:43
@samuelgrf
Copy link
Member Author

The GPLv3 license was added. I'll undraft the pr when I've found a good way to handle configuring the script.

@mweinelt
Copy link
Member

Looks like #92507 is obsoleting this PR. Can you take a look?

@samuelgrf
Copy link
Member Author

That implementation looks a lot nicer than mine, I've still got lots to learn. Closing this in favor of #92507 then.

@samuelgrf samuelgrf closed this Jul 24, 2020
@samuelgrf samuelgrf deleted the initpkg/sponsorblock-mpv-script branch March 5, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelgrf @mweinelt