Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facter: enable on darwin #92290

Merged
merged 4 commits into from Jul 4, 2020
Merged

facter: enable on darwin #92290

merged 4 commits into from Jul 4, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jul 4, 2020
@ofborg ofborg bot requested a review from womfoo July 4, 2020 19:19
@ludovicc
Copy link

ludovicc commented Jul 4, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin 19.5.0
  • executables tested on Darwin 19.5.0
  • all depending packages build
Possible improvements
Comments

@marsam marsam merged commit b0d53b7 into NixOS:master Jul 4, 2020
@marsam marsam deleted the enable-facter-darwin branch July 4, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @ludovicc