Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caprine: init at 2.48.0 #92289

Closed
wants to merge 1 commit into from
Closed

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Closes #90375

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Jul 4, 2020

The resulting output contains unnecessary dev dependencies, but there is currently no way to work around this using node2nix. See svanderburg/node2nix#149.

@kira-bruneau
Copy link
Contributor Author

Currently, the closure size is unnecessarily large because of all the included dev dependencies. If I find a better way to build this I will submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caprine
1 participant