Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typora: 0.9.73 -> 0.9.89 #92274

Merged
merged 1 commit into from Jul 5, 2020
Merged

typora: 0.9.73 -> 0.9.89 #92274

merged 1 commit into from Jul 5, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jul 4, 2020 •
edited by marsam

Motivation for this change

The package is currently broken due to the 404-ed URL.
This PR bumps the version and fixes the build.

Fixes #91838, fixes #89482 and fixes #76249.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 558.5MiB (~220MiB from itself)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jensbin July 4, 2020 14:42
@marsam marsam merged commit 27d76a8 into NixOS:master Jul 5, 2020
@oxalica oxalica deleted the bump/typora branch July 6, 2020 04:13
@worldofpeace
Copy link
Contributor

Is this an issue on stable? That means we'd need to backport. I'm assuming it is since the url 404d.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 7, 2020
@oxalica
Copy link
Contributor Author

oxalica commented Jul 7, 2020

@worldofpeace Yes, it's also broken on stable channels.
I should backport it to release-20.03, right?

@oxalica oxalica mentioned this pull request Jul 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensbin jensbin Awaiting requested review from jensbin

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
3 participants
@oxalica @worldofpeace @marsam