Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename coursier to launcher to cs #92276

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

tabdulradi
Copy link
Contributor

@tabdulradi tabdulradi commented Jul 4, 2020

This PR renames coursier's launcher to cs instead of coursier.

Motivation for this change

Consistency with Coursier's other installation methods.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asdf8dfafjk
Copy link
Contributor

I understand that coursier is a launcher besides being a dependency manager but the launcher part isn't really used that often by most people, is it? If so, 2 letter name is likely going to create unnecessary conflicts. Probably not a great idea.

@tabdulradi
Copy link
Contributor Author

I agree a 2 letter name might be problematic, and it's probably good idea to raise this concern at Coursier's issue tracker.
But also I don't think Nix as a package manager should change program names. Consistency is more important, otherwise running other people's scripts would be impossible.

@asdf8dfafjk
Copy link
Contributor

That's not a very intelligent argument- all application providers would try to use the least number of words and then wait for the first package manager to package it. Oh no, everyone now needs to use the same name otherwise "scripts will not work"

@SuperSandro2000 SuperSandro2000 marked this pull request as draft December 29, 2020 02:09
@stale
Copy link

stale bot commented Jun 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants