Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-music-scripts: fix build #92275

Merged
merged 1 commit into from Jul 4, 2020
Merged

google-music-scripts: fix build #92275

merged 1 commit into from Jul 4, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 4, 2020 •
edited

Motivation for this change

noticed it failing when reviewing #91488

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jbaum98 July 4, 2020 14:51
bhipple
bhipple reviewed Jul 4, 2020
View reviewed changes
pkgs/tools/audio/google-music-scripts/default.nix Show resolved Hide resolved
pkgs/tools/audio/google-music-scripts/default.nix
@@ -1,19 +1,36 @@
{ lib, python3 }:

with python3.pkgs;
let
py = python3.override {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if everywhere we did this, we used a composable form, like the one in #44426

As it stands, this wipes out any other overlays you have, so if you have something like an SSL cert fix for python certifi, your google-music-scripts pkg won't have it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is an application, and the main concern is just that we can do google-music-scripts ... , I don't think it's too much of a concern.

In general though, I agree, it would be nice if this was more composable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also related: #91850

@Ma27 Ma27 merged commit 59ce86a into NixOS:master Jul 4, 2020
@jonringer jonringer deleted the fix-google-music-scripts branch July 4, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple left review comments

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @bhipple @Ma27