Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sparse: fix tests #92216

Merged
merged 1 commit into from Jul 3, 2020
Merged

python3Packages.sparse: fix tests #92216

merged 1 commit into from Jul 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 3, 2020 •
edited

Motivation for this change

noticed it was failing when reviewing #91808

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 3, 2020 19:45
@jonringer
Copy link
Contributor Author 

______________ ERROR collecting sparse/tests/test_dask_interop.py ______________
sparse/tests/test_dask_interop.py:1: in <module>
    from dask.base import tokenize
E   ModuleNotFoundError: No module named 'dask'
______________ ERROR collecting sparse/tests/test_dask_interop.py ______________
ImportError while importing test module '/build/sparse-0.10.0/sparse/tests/test_dask_interop.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
sparse/tests/test_dask_interop.py:1: in <module>
    from dask.base import tokenize
E   ModuleNotFoundError: No module named 'dask'
=========================== short test summary info ============================
ERROR sparse/tests/test_dask_interop.py - ModuleNotFoundError: No module name...
ERROR sparse/tests/test_dask_interop.py
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 2 errors in 11.42s ==============================

@jonringer jonringer merged commit b9fd42d into NixOS:master Jul 3, 2020
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/92216
4 packages built:
python37Packages.sparse python37Packages.tensorly python38Packages.sparse python38Packages.tensorly

@jonringer jonringer deleted the fix-sparse-tests branch July 3, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer