kubebox: init at 0.8.0 #92243

blaggacao · 2020-07-04T02:12:59Z

(also updates a bunch of other stuff : !fear!)

Motivation for this change

Terminal and Web console for Kubernetes
closes #92200

Useful for prepping shell.nix in k8s projects c/o operations team.

Things done

blaggacao · 2020-07-04T02:17:44Z

The external effects in pkgs/development/node-packages/node-packages.nix seem scary to the freshman who did it.

Got it, it's normal

I did literally as told [by the docs](https://raw.githubusercontent.com/NixOS/nixpkgs/master/doc/languages-frameworks/node.section.md):

To add a package from NPM to nixpkgs:

Modify pkgs/development/node-packages/node-packages.json to add, update
or remove package entries to have it included in nodePackages and
nodePackages_latest.

Run the script: (cd pkgs/development/node-packages && ./generate.sh).

Build your new package to test your changes:
cd /path/to/nixpkgs && nix-build -A nodePackages.<new-or-updated-package>.
To build against the latest stable Current Node.js version (e.g. 14.x):
nix-build -A nodePackages_latest.<new-or-updated-package>

Add and commit all modified and generated files.

blaggacao · 2020-07-04T03:10:31Z

/marvin opt-in

marvin-mk2 · 2020-07-04T03:10:33Z

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

blaggacao · 2020-07-04T03:13:00Z

/status needs_reviewer

timokau · 2020-07-04T09:53:18Z

I'm not comfortable reviewing node PRs. git shortlog -n pkgs/development/node-packages/ suggests @Mic92 might be a better pick.

ludovicc · 2020-07-04T21:46:31Z

Reviewed points

package name fits guidelines
package version fits guidelines
package build on Darwin 19.05
executables tested on Darwin
all depending packages build

Possible improvements

Package failed to install on MacOS Darwin.

Comments

Logs from nixpkgs-review:

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 92243"

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/92243/head:refs/nixpkgs-review/1
remote: Enumerating objects: 41, done.
remote: Counting objects: 100% (34/34), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 17 (delta 14), reused 17 (delta 14), pack-reused 0
Unpacking objects: 100% (17/17), 41.10 KiB | 443.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   c4264d0f3a2..67a1c36929c  master               -> refs/nixpkgs-review/0
 + 883fdec768b...c8f6307c5e5 refs/pull/92243/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /Users/lclaude/.cache/nixpkgs-review/pr-92243/nixpkgs 67a1c36929cbbca7eab50469d4689cdde9cc153d
Preparing worktree (detached HEAD 67a1c36929c)
Updating files: 100% (22032/22032), done.
HEAD is now at 67a1c36929c cargo-watch: 7.4.1 -> 7.5.0
$ git merge --no-commit c8f6307c5e56e6c7535cc51bfa604d50140c82ec
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/lclaude/.cache/nixpkgs-review/pr-92243/build.nix
builder for '/nix/store/i70ffwgy44lmnfqcd8y6wqv1pfzpc8mh-racerd-unstable-2019-09-02.drv' failed with exit code 101; last 10 log lines:
     |                                                           ^^

  error: aborting due to 3 previous errors

  For more information about this error, try `rustc --explain E0061`.
  error: could not compile `rustc-ap-rustc_data_structures`.

  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
builder for '/nix/store/qbw3rlpjpa2fkk5kc2j517g1hd1gjgkp-lumo-1.10.1.drv' failed with exit code 1; last 10 log lines:
  ../deps/gtest/src/gtest.cc:376:12: warning: missing field 'owner_' initializer [-Wmissing-field-initializers]
  GTEST_API_ GTEST_DEFINE_STATIC_MUTEX_(g_linked_ptr_mutex);
             ^
  ../deps/gtest/include/gtest/internal/gtest-port.h:1949:80: note: expanded from macro 'GTEST_DEFINE_STATIC_MUTEX_'
       ::testing::internal::MutexBase mutex = { PTHREAD_MUTEX_INITIALIZER, false }
                                                                                 ^
  1 warning generated.
  rm 59243553c65631185418c5a71855a7890aad3ea9.intermediate
  make: *** [Makefile:100: node] Error 2
  ....> ERROR: The release executable has not been generated. This indicates a failure in the build process. There is likely additional information above.
builder for '/nix/store/k85c6kgfl67hvs71xypz75g4hzykbv8v-meguca-unstable-2019-03-12.drv' failed with exit code 2; last 10 log lines:
  cp node_modules/dom4/build/dom4.js node_modules/core-js/client/core.min.js node_modules/core-js/client/core.min.js.map www/js/vendor
  cp: cannot stat 'node_modules/dom4/build/dom4.js': No such file or directory
  cp: cannot stat 'node_modules/core-js/client/core.min.js': No such file or directory
  cp: cannot stat 'node_modules/core-js/client/core.min.js.map': No such file or directory
  make: *** [Makefile:42: client_vendor] Error 1
  make: *** Waiting for unfinished jobs....
  go: github.com/ErikDubbelboer/gspt@v0.0.0-20190125194910-e68493906b83: Get "https://proxy.golang.org/github.com/%21erik%21dubbelboer/gspt/@v/v0.0.0-20190125194910-e68493906b83.mod": dial tcp: lookup proxy.golang.org: no such host
  go: github.com/ErikDubbelboer/gspt@v0.0.0-20190125194910-e68493906b83: Get "https://proxy.golang.org/github.com/%21erik%21dubbelboer/gspt/@v/v0.0.0-20190125194910-e68493906b83.mod": dial tcp: lookup proxy.golang.org: no such host
  make: *** [Makefile:52: server] Error 1
  make: *** [Makefile:49: generate] Error 1
cannot build derivation '/nix/store/gqfh1dsl6idnsjyxv9v53hxkdyrfhpqf-ycmd-2020-02-22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hz5p2a0z60dp6krpcbp1ybp6qvzlcnir-vimplugin-YouCompleteMe-2020-07-03.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rrgfx5mjyikls09pagbpv769h0wxv9jl-env.drv': 4 dependencies couldn't be built
[106 built (3 failed), 1275 copied (3234.0 MiB), 995.5 MiB DL]
error: build of '/nix/store/rrgfx5mjyikls09pagbpv769h0wxv9jl-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/92243
4 packages failed to build:
lumo meguca vimPlugins.YouCompleteMe ycmd

1 package built:
iosevka

blaggacao · 2020-07-06T01:21:43Z

@ludovicc Thanks for your review, I suspect the results you obtained obey to unintended side effects of (cd pkgs/development/node-packages && ./generate.sh) - which is the textbook instruction of the node docs.

I was wondering anyhow if generating such huge amount of side effects is a good thing, and this might and in a deadlock, since I've no idea how to tackle this.

Looks like @Mic92 's judgment and opinion could help resolve this.

timokau · 2020-07-13T09:45:19Z

@adisbladis, maybe you could take a look? (again, git shortlog -n pkgs/development/node-packages/)

timokau · 2020-07-13T09:48:01Z

Huh, I thought I had implemented an automatic transition here.
/status awaiting_reviewer

nixos-discourse · 2020-07-25T18:07:26Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/232

Mic92 · 2020-07-30T05:12:25Z

I can merge after merge conflicts are resolved.

(also updates a bunch of other stuff : !fear!)

blaggacao · 2020-08-06T21:14:16Z

@Mic92 Just run generate again. Hope that's ok, now. I hope this huge side effects can be offloaded to a bot some day 😸

blaggacao · 2020-08-20T21:36:49Z

A friendly reminder, since I might not be able to do a rebase once again. It took 5 hours to download all packages...

marvin-mk2 · 2020-10-03T02:21:17Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

timokau · 2020-10-04T08:13:27Z

I'm sorry this PR was missed.

blaggacao · 2020-10-04T19:10:56Z

@timokau No worries, I've read the motion about node packages. I'm also currently no longer interested in kubebox since discovering k9s.

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 4, 2020

blaggacao force-pushed the da-add-kubebox branch from 31ab180 to c8f6307 Compare July 4, 2020 02:34

ofborg bot added the 8.has: package (new) label Jul 4, 2020

marvin-mk2 bot added the marvin label Jul 4, 2020

marvin-mk2 bot added the needs_reviewer label Jul 4, 2020

marvin-mk2 bot requested a review from timokau July 4, 2020 03:13

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Jul 4, 2020

marvin-mk2 bot added awaiting_changes and removed awaiting_reviewer labels Jul 4, 2020

timokau mentioned this pull request Jul 4, 2020

Do not transition to awaiting_changes when another review is requested via @mention timokau/marvin-mk2#44

Closed

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed awaiting_changes awaiting_reviewer labels Jul 6, 2020

marvin-mk2 bot requested a review from ryantm July 9, 2020 07:18

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed needs_reviewer awaiting_reviewer labels Jul 9, 2020

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed needs_reviewer awaiting_reviewer labels Jul 25, 2020

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Jul 30, 2020

blaggacao force-pushed the da-add-kubebox branch from c8f6307 to 11b870c Compare July 31, 2020 05:34

David Arnold added 2 commits August 6, 2020 14:32

kubebox: init at 0.8.0

46a29fd

(also updates a bunch of other stuff : !fear!)

node: run gen deps

8c19263

blaggacao force-pushed the da-add-kubebox branch from 11b870c to 8c19263 Compare August 6, 2020 19:34

ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 11-100 labels Aug 6, 2020

node: run gen deps again

faa0c63

marvin-mk2 bot added needs_reviewer and removed awaiting_reviewer labels Aug 10, 2020

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed needs_reviewer awaiting_reviewer labels Sep 19, 2020

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Sep 29, 2020

blaggacao closed this Oct 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubebox: init at 0.8.0 #92243

kubebox: init at 0.8.0 #92243

blaggacao commented Jul 4, 2020 •

edited

blaggacao commented Jul 4, 2020 •

edited

blaggacao commented Jul 4, 2020

marvin-mk2 bot commented Jul 4, 2020

blaggacao commented Jul 4, 2020

timokau commented Jul 4, 2020

ludovicc commented Jul 4, 2020

blaggacao commented Jul 6, 2020

timokau commented Jul 13, 2020

timokau commented Jul 13, 2020

nixos-discourse commented Jul 25, 2020

Mic92 commented Jul 30, 2020

blaggacao commented Aug 6, 2020

blaggacao commented Aug 20, 2020

marvin-mk2 bot commented Oct 3, 2020

timokau commented Oct 4, 2020

blaggacao commented Oct 4, 2020

kubebox: init at 0.8.0 #92243

kubebox: init at 0.8.0 #92243

Conversation

blaggacao commented Jul 4, 2020 • edited

Motivation for this change

Things done

blaggacao commented Jul 4, 2020 • edited

blaggacao commented Jul 4, 2020

marvin-mk2 bot commented Jul 4, 2020

blaggacao commented Jul 4, 2020

timokau commented Jul 4, 2020

ludovicc commented Jul 4, 2020

Reviewed points

Possible improvements

Comments

blaggacao commented Jul 6, 2020

timokau commented Jul 13, 2020

timokau commented Jul 13, 2020

nixos-discourse commented Jul 25, 2020

Mic92 commented Jul 30, 2020

blaggacao commented Aug 6, 2020

blaggacao commented Aug 20, 2020

marvin-mk2 bot commented Oct 3, 2020

timokau commented Oct 4, 2020

blaggacao commented Oct 4, 2020

blaggacao commented Jul 4, 2020 •

edited

blaggacao commented Jul 4, 2020 •

edited