Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pipdate: fix dependency management #92277

Merged
merged 1 commit into from Jul 4, 2020
Merged

python3Packages.pipdate: fix dependency management #92277

merged 1 commit into from Jul 4, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 4, 2020 •
edited

Motivation for this change

fix usage of "importlib_metadata"

upstream PR: nschloe/pipdate#41

used substituteInPlace to prevent breakign the build when it does get updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 4, 2020 15:05
@ofborg ofborg bot requested a review from costrouc July 4, 2020 15:13
@bhipple
Copy link
Contributor

bhipple commented Jul 4, 2020

Result of nixpkgs-review pr 92277 1

4 packages failed to build:
- python37Packages.accupy
- python37Packages.perfplot
- python38Packages.accupy
- python38Packages.perfplot
2 packages built:
- python37Packages.pipdate
- python38Packages.pipdate

@bhipple
Copy link
Contributor

bhipple commented Jul 4, 2020

Broken pkgs are also broken on master, of course.

λ brh nixpkgs →  hydra python37Packages.accupy python37Packages.perfplot
********************************************************************************
Unstable:
Build Status for nixpkgs.python37Packages.accupy.x86_64-linux on unstable
✖ (Dependency failed) python3.7-accupy-0.3.1 from 2020-06-26 - https://hydra.nixos.org/build/123244897

Last Builds:
✖ (Dependency failed) python3.7-accupy-0.3.1 from 2020-06-20 - https://hydra.nixos.org/build/122656031
✖ (Dependency failed) python3.7-accupy-0.3.1 from 2020-06-19 - https://hydra.nixos.org/build/122605221
✔ python3.7-accupy-0.2.0 from 2020-06-15 - https://hydra.nixos.org/build/122277844
✔ python3.7-accupy-0.2.0 from 2020-06-11 - https://hydra.nixos.org/build/122061911
✔ python3.7-accupy-0.2.0 from 2020-05-29 - https://hydra.nixos.org/build/120806810
✖ (Failed) python3.7-accupy-0.2.0 from 2020-05-12 - https://hydra.nixos.org/build/119080690
✔ python3.7-accupy-0.2.0 from 2020-05-08 - https://hydra.nixos.org/build/118568342
✔ python3.7-accupy-0.2.0 from 2020-05-06 - https://hydra.nixos.org/build/118332511
✔ python3.7-accupy-0.2.0 from 2020-04-28 - https://hydra.nixos.org/build/117844444
Build Status for nixpkgs.python37Packages.perfplot.x86_64-linux on unstable
✖ (Dependency failed) python3.7-perfplot-0.5.0 from 2020-06-26 - https://hydra.nixos.org/build/123246398

Last Builds:
✖ (Dependency failed) python3.7-perfplot-0.5.0 from 2020-06-20 - https://hydra.nixos.org/build/122663005
✖ (Dependency failed) python3.7-perfplot-0.5.0 from 2020-06-19 - https://hydra.nixos.org/build/122623074
✔ python3.7-perfplot-0.5.0 from 2020-06-15 - https://hydra.nixos.org/build/122277932
✔ python3.7-perfplot-0.5.0 from 2020-06-11 - https://hydra.nixos.org/build/122075237
✔ python3.7-perfplot-0.5.0 from 2020-05-29 - https://hydra.nixos.org/build/120818863
✔ python3.7-perfplot-0.5.0 from 2020-05-12 - https://hydra.nixos.org/build/119082728
✔ python3.7-perfplot-0.5.0 from 2020-05-08 - https://hydra.nixos.org/build/118566487
✔ python3.7-perfplot-0.5.0 from 2020-05-06 - https://hydra.nixos.org/build/118335646
✔ python3.7-perfplot-0.5.0 from 2020-04-28 - https://hydra.nixos.org/build/117853164
********************************************************************************
Release 20.03:
Build Status for nixpkgs.python37Packages.accupy.x86_64-linux on 20.03
✔ python3.7-accupy-0.2.0 from 2020-06-28 - https://hydra.nixos.org/build/123314959
Build Status for nixpkgs.python37Packages.perfplot.x86_64-linux on 20.03
✔ python3.7-perfplot-0.5.0 from 2020-06-28 - https://hydra.nixos.org/build/123283298

@bhipple bhipple merged commit 0eabb1b into NixOS:master Jul 4, 2020
@jonringer jonringer deleted the fix-pipdate branch July 4, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @bhipple