Nixops ssh conn quantity and stderr fixup #1380

johnalotoski · 2020-07-05T03:46:06Z

Fixes issue Too many nixops SSH "master" sockets #1375, too many ssh conns, as observed in testing with nixops-packet plugin Update to nixops 2.0, python3, poetry, types input-output-hk/nixops-packet#21. Not yet tested with other plugins.
The recent tcp port probe to ssh probe change (362d049) introduced threaded workers which persist in their ssh conn task despite event blocking timing out. Adding an ssh connecttimeout to match the event block timeout resolves the buildup of worker threads.
An option for suppression of ssh master stderr was added to enable ssh status probes to avoid outputting large quantities of expected stderr messages to the user.

adisbladis · 2020-07-07T14:19:49Z

Great stuff, works nicely. Thanks!

johnalotoski added 2 commits July 4, 2020 23:14

Resolves ssh conn accumuluation with a connecttimeout

0bc9a09

Adds ssh_quiet to suppress stderr during status checks

0ed698c

adisbladis merged commit a287225 into NixOS:master Jul 7, 2020

adisbladis mentioned this pull request Jul 8, 2020

Too many nixops SSH "master" sockets #1375

Closed

Provide feedback