Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.prawcore: disable on python2 #92279

Merged
merged 1 commit into from Jul 4, 2020
Merged

python2Packages.prawcore: disable on python2 #92279

merged 1 commit into from Jul 4, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 4, 2020 •
edited

Motivation for this change

no longer compatible with python2's urllib

  prawcore/exceptions.py:2: in <module>
      from urllib.parse import urlparse
  E   ImportError: No module named parse
  builder for '/nix/store/3l1rqygq58hbwyzn6fqx8x4djbmzgggh-python2.7-prawcore-1.4.0.drv' failed with exit code

upstream PR: praw-dev/prawcore#101

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-92279/nixpkgs -qaP --xml --out-path --show-trace --meta
nix-b	2 packages removed:
python2.7-praw (†6.3.1) python2.7-prawcore (†1.4.0)

Nothing changed
https://github.com/NixOS/nixpkgs/pull/92279
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-92279/shell.nix

@jonringer
python2Packages.prawcore: disable on python2
01f1f3d 
no longer compatible with python2's urllib

```
  prawcore/exceptions.py:2: in <module>
      from urllib.parse import urlparse
  E   ImportError: No module named parse
  builder for '/nix/store/3l1rqygq58hbwyzn6fqx8x4djbmzgggh-python2.7-prawcore-1.4.0.drv' failed with exit code
```
@jonringer jonringer requested a review from FRidh as a code owner July 4, 2020 15:34
@Ma27 Ma27 merged commit eb7113f into NixOS:master Jul 4, 2020
@jonringer jonringer deleted the prawcore-disable-py2 branch July 4, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Ma27