Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] chocolateDoom: 2.3.0 -> 3.0.1 (CVE-2020-14983) #92248

Merged
merged 2 commits into from Jul 10, 2020
Merged

[20.03] chocolateDoom: 2.3.0 -> 3.0.1 (CVE-2020-14983) #92248

merged 2 commits into from Jul 10, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 4, 2020

Motivation for this change

Fixes CVE-2020-14983:

https://github.com/chocolate-doom/chocolate-doom/blob/539ef367c9982c5945f8608b63d2236eaecc929a/NEWS.md#301-2020-06-24

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

AXDOOMER and others added 2 commits July 4, 2020 08:19
@AXDOOMER @danieldk
chocolate-doom: 2.3.0 -> 3.0.0
2142fbf 
(cherry picked from commit 134f200)
@r-ryantm @danieldk
chocolateDoom: 3.0.0 -> 3.0.1
812cc85 
(cherry picked from commit ea7fc40)
@danieldk danieldk changed the title chocolateDoom: 2.3.0 -> 3.0.1 (CVE-2020-14983) [20.03] chocolateDoom: 2.3.0 -> 3.0.1 (CVE-2020-14983) Jul 4, 2020
@ofborg ofborg bot requested a review from MP2E July 4, 2020 06:31
@danieldk danieldk mentioned this pull request Jul 5, 2020
Closed
10 tasks
@MP2E
Copy link

MP2E commented Jul 10, 2020

LGTM. Thanks!

@MP2E MP2E merged commit d289165 into NixOS:release-20.03 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @MP2E @AXDOOMER @r-ryantm