rippled: 1.4.0 -> 1.5.0 #92308
Merged
rippled: 1.4.0 -> 1.5.0 #92308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
marsam
reviewed
Jul 5, 2020
| @@ -6486,6 +6486,12 @@ | |||
| githubId = 131856; | |||
| name = "Arnout Engelen"; | |||
| }; | |||
| RaghavSood = { | |||
There was a problem hiding this comment.
please separate this into another commit
pkgs/servers/rippled/default.nix
Outdated
| "-DBOOST_LIBRARYDIR=${boost.out}/lib" | ||
| "-DBOOST_INCLUDEDIR=${boost.dev}/include" | ||
| ]; | ||
| cmakeFlags = ["-Dstatic=OFF" "-DBoost_NO_BOOST_CMAKE=ON" "-DCMAKE_BUILD_TYPE=Release"]; |
There was a problem hiding this comment.
cmake hook already adds CMAKE_BUILD_TYPE
Suggested change
| cmakeFlags = ["-Dstatic=OFF" "-DBoost_NO_BOOST_CMAKE=ON" "-DCMAKE_BUILD_TYPE=Release"]; | |
| cmakeFlags = ["-Dstatic=OFF" "-DBoost_NO_BOOST_CMAKE=ON" ]; |
There was a problem hiding this comment.
Ah, interesting - updated
pkgs/servers/rippled/default.nix
Outdated
|
|
||
| preConfigure = '' | ||
| export HOME=$PWD | ||
|
|
||
| echo $HOME && ls -al |
There was a problem hiding this comment.
would you mind deleting this line?
There was a problem hiding this comment.
Apologies, that was for debugging - removed
offlinehacker
approved these changes
Jul 6, 2020
|
We used rippled from nixpkgs in my previous company, but since I left, I did not keep it updated, well they seem to not use this package anymore. |
|
@offlinehacker thanks for the merge! I work at an exchange, and we do use rippled :) Should be able to keep it up to date with minimal effort |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Ripple has undergone a network upgrade and rippled 1.4.0 no longer syncs
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)