chore: make pr templ more beginnger friendly #92244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: policy discussion
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
Mic92
reviewed
Jul 4, 2020
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. --> | ||
| <!-- | ||
| Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. | ||
| You might find this discussion useful: https://discourse.nixos.org/t/making-the-pull-request-template-more-beginner-friendly-nixpkgs/388 |
There was a problem hiding this comment.
We should point to documentation in this repository rather than discourse discussions.
There is .github/CONTRIBUTING.md if you want to add something. Discussions are harder to consume than a concise description of what these points mean.
Mic92
reviewed
Jul 7, 2020
Mic92
reviewed
Jul 7, 2020
|
Is this all you want to change? |
|
I think #92612 addresses the root cause better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://discourse.nixos.org/t/making-the-pull-request-template-more-beginner-friendly-nixpkgs/388