libwebsockets: Change default CMake flags for package #92291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just always enable them? Unless they experimental or blow up the package size too much, I would just always include them. |
|
Sure, if that is the preferred way of handling such things. I am not attached to having these configuration options and would in fact prefer just adding the non-standard flags to the package, if that would be accepted. |
|
@jtojnar I've now removed the package options and just added the required CMake flags unconditionally. |
leotaku
changed the title
|
Looks like there are some conflicts. Could you please rebase and squash? |
The libwebsockets package is now built with support for IPv6 and SOCKS5 in addition to general plugin support.
leotaku
force-pushed
the
libwebsockets-options
branch
from
5e98109
to
7436729
Compare
|
Thanks. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some configuration options to the libwebsockets package.
withPlugins:: Plugin support, this was already present but used to be non-configurablewithIPv6:: IPv6 supportwithSocks5:: Socks5 supportLibwebsockets has numerous other configuration options which can be found here.
I'm not quite sure if it makes sense to support all of them in nixpkgs, but I would of course be willing to add them.
Motivation for this change
This is a prerequisite to #91549, as cloud support for netdata requires a libwebsockets build with non-default options.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)