Wine update: 5.11 -> 5.12 #92295
Merged
Wine update: 5.11 -> 5.12 #92295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: it works faster, and don't issue suspicious errors like `sed: couldn't flush stdout: Broken pipe` during applying patches.
SFrijters
suggested changes
Jul 5, 2020
There was a problem hiding this comment.
From the user point of view it looks good to me: built it and used it to run the Windows applications I normally use with Wine and they work (as well as before). One of them is foobar2000 so this also tests the faudio update to some extent.
From a style point of view I'm not the best person to ask, but I have one suggestion.
pkgs/misc/emulators/wine/staging.nix
Outdated
| @@ -1,4 +1,4 @@ | |||
| { stdenv, callPackage, wineUnstable }: | |||
| { lib, stdenv, callPackage, wineUnstable }: | |||
There was a problem hiding this comment.
The other lib in this file are used as stdenv.lib, so do we want it as an extra argument for concatMapStringsSep?
There was a problem hiding this comment.
ok, will use stdenv.lib as well
Due repeatable issues with xactengine-initial patchset. Later, `disablePatchsets` can be extended to be overridable argument of wineStaging.
SFrijters
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Keep wine unstable/staging up to date.
Also allows to disable specific patchsets from staging
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)