whatmp3: init at 3.8 #92296
Closed
whatmp3: init at 3.8 #92296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jul 6, 2020
jtojnar
reviewed
Jul 6, 2020
jtojnar
reviewed
Jul 6, 2020
|
Good suggestions, thank you. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
mdlayher
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
LGTM!
✔ ~/src/github.com/nixos/nixpkgs [master|✔]
11:50 $ nixpkgs-review pr 92296
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/92296/head:refs/nixpkgs-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 9 (delta 6), reused 6 (delta 6), pack-reused 3
Unpacking objects: 100% (9/9), 1.21 KiB | 51.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
a54cd1cace0..56619d6ebb7 master -> refs/nixpkgs-review/0
+ bdd65f3f69d...6329518af37 refs/pull/92296/head -> refs/nixpkgs-review/1 (forced update)
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-92296/nixpkgs 56619d6ebb7bef4f379fd909d6909d93b3121131
Preparing worktree (detached HEAD 56619d6ebb7)
HEAD is now at 56619d6ebb7 Merge pull request #85992 from symphorien/ibus-db
$ git merge --no-commit 6329518af37151d6ba3a6726ac8b25262e513f9c
Auto-merging pkgs/top-level/all-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-92296/build.nix
[3 built, 115 copied (359.8 MiB), 80.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/92296
1 package built:
whatmp3
$ nix-shell /home/matt/.cache/nixpkgs-review/pr-92296/shell.nix
these paths will be fetched (1.51 MiB download, 8.27 MiB unpacked):
/nix/store/a4zs0slb4fmmr3js1ik2ckl282515k62-bash-interactive-4.4-p23-doc
/nix/store/csdsyicqjal4viixw4ispx2hi17r0pz5-readline-7.0p5
/nix/store/fdc7zi9sk8jlmw0rshcb585xawxb2r5m-bash-interactive-4.4-p23-dev
/nix/store/k0bldh4a1blg50psfjfkmmsap6zkx9d1-bash-interactive-4.4-p23-man
/nix/store/x4gd806afbgx0ag1jf8y7blzrrhiyx8q-bash-interactive-4.4-p23
/nix/store/x718i4nnyhz46hrgmhb3xq6sijaq845x-bash-interactive-4.4-p23-info
copying path '/nix/store/a4zs0slb4fmmr3js1ik2ckl282515k62-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/x718i4nnyhz46hrgmhb3xq6sijaq845x-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/k0bldh4a1blg50psfjfkmmsap6zkx9d1-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/csdsyicqjal4viixw4ispx2hi17r0pz5-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/x4gd806afbgx0ag1jf8y7blzrrhiyx8q-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/fdc7zi9sk8jlmw0rshcb585xawxb2r5m-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
[nix-shell:~/.cache/nixpkgs-review/pr-92296]$ ./results/whatmp3/bin/whatmp3 --version
.whatmp3-wrapped 3.8
SuperSandro2000
requested changes
Nov 29, 2020
Comment on lines
+5
to
+6
| version = "3.8"; | ||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
Suggested change
| version = "3.8"; | |
| src = fetchFromGitHub { | |
| version = "3.8"; | |
| src = fetchFromGitHub { |
Comment on lines
+7
to
+10
| rev = "v3.8"; | ||
| owner = "RecursiveForest"; | ||
| repo = "whatmp3"; | ||
| sha256 = "0vqczxdk90sdld0yxgc1kknlyszmb4ys1bhr53n39nbhgwssh1df"; |
There was a problem hiding this comment.
Suggested change
| rev = "v3.8"; | |
| owner = "RecursiveForest"; | |
| repo = "whatmp3"; | |
| sha256 = "0vqczxdk90sdld0yxgc1kknlyszmb4ys1bhr53n39nbhgwssh1df"; | |
| owner = "RecursiveForest"; | |
| repo = "whatmp3"; | |
| rev = "v${version}"; | |
| sha256 = "0vqczxdk90sdld0yxgc1kknlyszmb4ys1bhr53n39nbhgwssh1df"; |
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "whatmp3 transcodes audio files and creates torrents for them"; |
There was a problem hiding this comment.
Suggested change
| description = "whatmp3 transcodes audio files and creates torrents for them"; | |
| description = "Transcodes audio files and creates torrents of them"; |
|
Result of 1 package built:
|
|
Result of 1 package marked as broken and skipped:
|
|
Sorry, I no longer think this is worth adding to nixpkgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)