Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rlite: init at 2020-03-31 #92241

Closed
wants to merge 1 commit into from
Closed

rlite: init at 2020-03-31 #92241

wants to merge 1 commit into from

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Jul 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasj19
Copy link
Contributor

dasj19 commented Jul 12, 2020

Interesting project. Just tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 92241"

Results:


error: build of '/nix/store/jgahhaw0hmrymsvdyik1fm401zk81mgy-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/92241
2 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.rlite linuxPackages_hardkernel_latest.rlite

6 packages failed to build:
linuxPackages_5_6.rlite linuxPackages_5_7.rlite linuxPackages_latest-libre.rlite linuxPackages_latest_hardened.rlite linuxPackages_latest_xen_dom0.rlite linuxPackages_latest_xen_dom0_hardened.rlite

10 packages built:
linuxPackages-libre.rlite linuxPackages.rlite linuxPackages_4_14.rlite linuxPackages_4_19.rlite linuxPackages_4_4.rlite linuxPackages_4_9.rlite linuxPackages_hardened.rlite linuxPackages_testing_bcachefs.rlite linuxPackages_xen_dom0.rlite linuxPackages_xen_dom0_hardened.rlite

SuperSandro2000
SuperSandro2000 requested changes Nov 29, 2020
View reviewed changes
pkgs/os-specific/linux/rlite/default.nix Outdated
, enable-python ? false
, enable-wifi ? false
}:
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove let in and move it into rec.

pkgs/os-specific/linux/rlite/default.nix Outdated
, enable-wifi ? false
}:
let
deps = [ which cmake protobuf ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and move it to the correct location.

pkgs/os-specific/linux/rlite/default.nix Outdated
description = "A light RINA implementation";
homepage = https://github.com/rlite/rlite;
license = licenses.lgpl21;
maintainers = [ maintainers.twey ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ maintainers.twey ];
maintainers = with maintainers; [ twey ];

pkgs/os-specific/linux/rlite/default.nix Outdated
sha256 = "1gngcxxl792lqpwdvxqzlajgx3rgxaksxdbj55hjcr4d3qiqq905";
};

buildInputs = stdenv.lib.concatLists [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ++ instead of concatLists.

@dasj19
Copy link
Contributor

dasj19 commented Apr 29, 2021

This is waiting for some time... can you apply Sandro's comments so we can move on to approval and merge? Thanks.

@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md and removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Oct 30, 2021
SuperSandro2000
SuperSandro2000 requested changes Nov 22, 2021
View reviewed changes
pkgs/os-specific/linux/rlite/default.nix
Comment on lines +41 to +42
buildPhase = "make -j$NIX_BUILD_CORES";
installPhase = "make install";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should be done automatically. Please give removing this a try.

pkgs/os-specific/linux/rlite/default.nix
./strip-hardcoded-usr-install-prefix.patch
];

postUnpack = "patchShebangs .";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be postPatch. Which files exactly?

pkgs/os-specific/linux/rlite/default.nix
Comment on lines +27 to +28
++ stdenv.lib.optionals enable-python [ python swig ]
++ stdenv.lib.optionals enable-wifi [ wpa_supplicant hostapd ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
++ stdenv.lib.optionals enable-python [ python swig ]
++ stdenv.lib.optionals enable-wifi [ wpa_supplicant hostapd ];
++ lib.optionals enable-python [ python swig ]
++ lib.optionals enable-wifi [ wpa_supplicant hostapd ];

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@Twey
Copy link
Contributor Author

Twey commented Feb 12, 2023

Sorry, I ran out of time to work on this, and since the upstream project has stagnated it no longer compiles on recent Linux. I'm closing this PR.

@Twey Twey closed this Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twey @dasj19 @SuperSandro2000