Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.13.29 -> 5.13.32 #92225

Merged
merged 2 commits into from Jul 11, 2020
Merged

unifiStable: 5.13.29 -> 5.13.32 #92225

merged 2 commits into from Jul 11, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Jul 3, 2020 •
edited

Motivation for this change

Update to latest version, and make sure the service restarts on update.

Not restarting after a package update seems to work in some cases but after this update it was left in a broken state.
Manually restarting the service helped. I think it's a good idea to always restart on update to be on the safe side.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bachp added 2 commits July 3, 2020 22:33
@bachp
unifiStable: 5.13.29 -> 5.13.32
2a9765e
@bachp
nixos/unifi: restart service on package update
3e7d650 
Currently the service doesn't detect if on of the packages is updated
and doesn't restart.

By manually adding a trigger we make sure the service restarts if any of
the involved packages update.
@ofborg ofborg bot requested review from globin and erictapen July 3, 2020 20:42
erictapen
erictapen approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me. Thanks also for the restartTriggers, didn't know about that mechanism!

Btw: How do you get notified about Unifi releases? I once subscriped to a mailing list where I get an email for every new release (didn't find the link but the mails come from notifications@community.ui.com), but every time I try to bump the package, the file isn't available yet. A few days later, your create an PR and the release is available.

@bachp
Copy link
Member Author

bachp commented Jul 7, 2020

@erictapen I usually get notified by the unifi UI that a new release is available. So no system behind it.

@erictapen erictapen merged commit ce111fc into NixOS:master Jul 11, 2020
@bachp bachp deleted the unifi-5.13.32 branch July 11, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @erictapen