Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] teams: 1.3.00.958 -> 1.3.00.16851 #92230

Merged
merged 2 commits into from Jul 4, 2020
Merged

[20.03] teams: 1.3.00.958 -> 1.3.00.16851 #92230

merged 2 commits into from Jul 4, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 3, 2020

Motivation for this change
  • because of electron and since it depends on external services, we should backport applications
    such as teams

cc @devhell @liff

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

liff and others added 2 commits July 3, 2020 23:00
@liff @Mic92
teams: 1.3.00.958 -> 1.3.00.5153
5f739b6 
(cherry picked from commit 898a3bf)
@devhell @Mic92
teams: 1.3.00.5152 -> 1.3.00.16851
97f8181 
Microsoft finally released a new version for Linux.

(cherry picked from commit 6450f9e)
@ofborg ofborg bot requested a review from liff July 3, 2020 22:11
@Mic92 Mic92 merged commit 9f48aa9 into NixOS:release-20.03 Jul 4, 2020
@Mic92 Mic92 deleted the teams-backport branch July 4, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liff liff liff approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @liff @devhell