Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pylint: Move toml to propagatedBuildInputs #92297

Closed
wants to merge 1 commit into from
Closed

python3Packages.pylint: Move toml to propagatedBuildInputs #92297

wants to merge 1 commit into from

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jul 4, 2020 •
edited

Motivation for this change

Otherwise pylint doesn’t run at all:

$ nix-shell --pure -p python3Packages.pylint --run 'pylint --help'
Traceback (most recent call last):
  …
  File "/nix/store/bl24al9s9pckbqyf54p8yqfig4l17ar6-python3.8-pylint-2.5.2/lib/python3.8/site-packages/pylint/config.py", line 54, in <module>
    import toml
ModuleNotFoundError: No module named 'toml'

(Could also be propagatedNativeBuildInputs, but there’s no native code in the toml package, nor any binaries in PATH.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
python3Packages.pylint: Move toml to propagatedBuildInputs
8c80751 
Otherwise pylint doesn’t run at all:

$ nix-shell --pure -p python3Packages.pylint --run 'pylint --help'
Traceback (most recent call last):
  …
  File "/nix/store/bl24al9s9pckbqyf54p8yqfig4l17ar6-python3.8-pylint-2.5.2/lib/python3.8/site-packages/pylint/config.py", line 54, in <module>
    import toml
ModuleNotFoundError: No module named 'toml'

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@jonringer
Copy link
Contributor

done as part of #91489

@jonringer jonringer closed this Jul 4, 2020
@jonringer
Copy link
Contributor

@andersk thank you for making the PR though :)

@andersk andersk deleted the pylint branch December 26, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @jonringer