firefox: support for PKCS#11 modules in wrapper #92251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
force-pushed
the
pr/firefox-pkcs11-modules
branch
from
7143cba
to
12732ef
Compare
|
Some pkcs11 changes appear to be happening in #91746. |
I don't expect that this will impact the firefox functionality, but I'd be willing to check everything again once the nss and firefox updates hit unstable. |
chvp
force-pushed
the
pr/firefox-pkcs11-modules
branch
from
12732ef
to
1e245e3
Compare
chvp
force-pushed
the
pr/firefox-pkcs11-modules
branch
2 times, most recently
from
4da6ffd
to
a8d0b4e
Compare
|
The NSS update is in master now (and most binaries are available already). If it (still) works for you, I see no reason to wait with merging it. |
Still works (both on a clean firefox profile and my usual firefox profile). |
chvp
force-pushed
the
pr/firefox-pkcs11-modules
branch
from
a8d0b4e
to
194d749
Compare
vcunat
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Configuring the middleware for the Belgian eID in firefox required some manual work, that still left the PKCS#11 in a weird state since (at least on my machines) the firefox extension sends a notification warning about the PKCS#11 module being missing (even though the functionality worked). This adds an extra option similar to
extraNativeMessagingHosts(added in #31572) that allows configuring PKCS#11 modules in the firefox wrapper. This fixed all papercuts related to the eID middleware (manually adding it is no longer required and there is no longer a notification on startup).Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)