Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoxide: 0.4.1 -> 0.4.3 #92250

Merged
merged 1 commit into from Jul 5, 2020
Merged

zoxide: 0.4.1 -> 0.4.3 #92250

merged 1 commit into from Jul 5, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jul 4, 2020 •
edited

ajeetdsouza/zoxide@v0.4.1...v0.4.3

Also removes unnecessary rec and stdenv.

Motivation for this change

New release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ysndr July 4, 2020 08:22
@cole-h
zoxide: 0.4.1 -> 0.4.3
ee33c73 
ajeetdsouza/zoxide@v0.4.1...v0.4.3

Also removes unnecessary `rec` and `stdenv`.
@cole-h cole-h changed the title zoxide: 0.4.1 -> 0.4.2 zoxide: 0.4.1 -> 0.4.3 Jul 4, 2020
@ludovicc
Copy link

ludovicc commented Jul 4, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin 19.5.0
  • executables tested on Darwin 19.5.0
  • all depending packages build
Possible improvements
Comments

marsam
marsam reviewed Jul 5, 2020
View reviewed changes
pkgs/tools/misc/zoxide/default.nix
}:

rustPlatform.buildRustPackage rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why do you prefer let over rec?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to stay away from rec as much as possible because I think it's cleaner. I seem to remember that I had (or read) a conversation about rec vs let on IRC a while back (I think it was with @adisbladis. If not, sorry for the ping), but I can't find it in my logs (it was probably in April or prior to the end of May). I believe it boiled down to rec-less being faster to evaluate?

ysndr
ysndr reviewed Jul 5, 2020
View reviewed changes
Copy link
Member

@ysndr ysndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs successfully on macos

@bhipple
Copy link
Contributor

bhipple commented Jul 5, 2020

Result of nixpkgs-review pr 92250 1

1 package built:
- zoxide

@bhipple bhipple merged commit 5a0af8e into NixOS:master Jul 5, 2020
@cole-h cole-h deleted the zoxide branch July 5, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@bhipple bhipple bhipple approved these changes

@ysndr ysndr ysndr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cole-h @ludovicc @bhipple @marsam @ysndr