Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/data/fonts: merge back the split otb output #95907

Merged
merged 1 commit into from Aug 23, 2020
Merged

pkgs/data/fonts: merge back the split otb output #95907

merged 1 commit into from Aug 23, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 21, 2020 •
edited

Motivation for this change

Since the Pango issue 457 has been fixed and Nixpkgs patched, it's no longer necessary to keep X11 and .otb fonts in separate outputs (previously they would cause application to display broken fonts).
Linked to #75160, also.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change: all good expect already broken ones.
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj added this to the 20.09 milestone Aug 21, 2020
@rnhmjoj
pkgs/data/fonts: merge back the split otb output
6545e5a 
Since the Pango issue 457[1] has been fixed and Nixpkgs patched, it's no
longer necessary to keep X11 and .otb fonts in separate outputs (previously
they would cause application to display broken fonts).

[1]: https://gitlab.gnome.org/GNOME/pango/-/issues/457
@rnhmjoj rnhmjoj mentioned this pull request Aug 22, 2020
Closed
@jonringer jonringer added this to To Do in 20.09 Blockers via automation Aug 22, 2020
@7c6f434c 7c6f434c merged commit f467d79 into NixOS:master Aug 23, 2020
20.09 Blockers automation moved this from To Do to Done Aug 23, 2020
@rnhmjoj rnhmjoj mentioned this pull request Aug 30, 2020
Closed
19 tasks
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 5, 2020
@worldofpeace worldofpeace removed this from Done in 20.09 Blockers Oct 5, 2020
@worldofpeace worldofpeace moved this from In progress to Done in 20.09 Blockers Oct 5, 2020
@rnhmjoj rnhmjoj deleted the otb-merge branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
No open projects
20.09 Blockers
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @7c6f434c