charliecloud: 0.12 -> 0.18 #95888
charliecloud: 0.12 -> 0.18 #95888
Conversation
|
Thank you! Greatly appreciate our packagers. :) |
Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
bzizou
force-pushed
the
charliecloud18
branch
2 times, most recently
from
bf602e4
to
0779ea1
Compare
There was a problem hiding this comment.
Thanks for all the work you have put in! I think the derivation has become much more robust as a result.Two final requested changes:
- Add
sudoto the wrapper. - Remove the test from this PR, with a suggestion of you the test could be structured to automatically run by Hydra/ofborg.
Then it should be ready for merging.
| @@ -0,0 +1,42 @@ | |||
| #/bin/env bash | |||
There was a problem hiding this comment.
Having a test is nice, but it is probably not so useful when they are not run automatically. Such tests tend to get stale over time.
What you could do in another PR when this one is merged, if you are interested in putting in the time, is write a NixOS test. If you are not familiar with NixOS tests, they run in a VM and therefore provide the opportunity to set up a real testing environment. E.g., you could automatically set up a Docker registry in the test (there is already a NixOS test that does this, that can be used for inspiration, nixos/tests/docker-registry.nix) and then test charliecloud against that registry.
Then that test could be added to passthru.tests in this derivation and it would be run automatically by ofborg and Hydra.
There was a problem hiding this comment.
Okay! I wrote the test. I used dockerTools.examples.nix as a base image. Hope this is fine.
There was a problem hiding this comment.
Great! I amended the commit, seems that you forgot to commit the change to alltests.nix. So, should be good now.
Let's see if ofborg is also happy.
There was a problem hiding this comment.
Oh, yes sorry. Ofborg has passed the passthru.tests.charliecloud test anyway, I checked that
There was a problem hiding this comment.
It didn't, it just skips that step if passthru.tests cannot be properly be evaluated.
danieldk
force-pushed
the
charliecloud18
branch
from
30260e0
to
96e0cbe
Compare
|
@ofborg build charliecloud |
danieldk
force-pushed
the
charliecloud18
branch
from
96e0cbe
to
1601ff7
Compare
|
@ofborg eval |
|
Many thanks for your help @danieldk ! |
|
Thanks for packaging Charliecloud!! Very much appreciate your efforts. And please do let us know if upstream can do anything to make you work easier. |
Motivation for this change
An important bug has been fixed https://github.com/hpc/charliecloud/pull/826/files
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)